search

localgovdrupal / localgov_alert_banner

Alert banner module for LocalGovDrupal
GNU General Public License v2.0
5 stars 8 forks source link

Address deprecation notices to prepare for Drupal 10 #193

Closed finnlewis closed 11 months ago

finnlewis commented 2 years ago

When running the tests locally, I get the following, so just logging here so we can start a branch to address the deprecation notices.

$ lando phpunit web/modules/contrib/localgov_alert_banner/
PHPUnit 9.5.20 #StandWithUkraine

Testing /app/web/modules/contrib/localgov_alert_banner
Admin View (Drupal\Tests\localgov_alert_banner\Functional\AdminView)
 ✔ Load admin view

Alert Banner Block (Drupal\Tests\localgov_alert_banner\Functional\AlertBannerBlock)
 ✔ Alert banner displays
 ✔ Non live alert banner does not display
 ✔ Alert display title
 ✔ Alert remove hide link
 ✔ Alert banner type display

Alert Confirmation (Drupal\Tests\localgov_alert_banner\Functional\AlertConfirmation)
 ✔ Alert confirmation
 ✔ Save alert redirect

Permissions (Drupal\Tests\localgov_alert_banner\Functional\Permissions)
 ✔ Alert banner user access

Views Status Link (Drupal\Tests\localgov_alert_banner\Functional\ViewsStatusLink)
 ✔ Entity link

Visibility (Drupal\Tests\localgov_alert_banner\Functional\Visibility)
 ✔ Alert banner visibility

Alert Banner Hide (Drupal\Tests\localgov_alert_banner\FunctionalJavascript\AlertBannerHide)
 ✔ Alert banner hide

Alert Banner Block Order (Drupal\Tests\localgov_alert_banner\Kernel\AlertBannerBlockOrder)
 ✔ Alert banner block order

Scheduling Install (Drupal\Tests\localgov_alert_banner\Kernel\SchedulingInstall)
 ✔ Enable scheduled transitions
 ✔ Enable local gov alert banner

Scheduling (Drupal\Tests\localgov_alert_banner\Kernel\Scheduling)
 ✔ Alert banner scheduling

Time: 01:09.019, Memory: 14.00 MB

OK (16 tests, 241 assertions)

Remaining self deprecation notices (130)

  69x: The core/jquery.cookie asset library is deprecated in Drupal 9.0.0 and will be removed in Drupal 10.0.0. Use the core/js-cookie library instead. See https://www.drupal.org/node/3104677
    49x in PermissionsTest::testAlertBannerUserAccess from Drupal\Tests\localgov_alert_banner\Functional
    7x in AlertConfirmationTest::testAlertConfirmation from Drupal\Tests\localgov_alert_banner\Functional
    5x in AlertBannerBlockTest::testAlertBannerTypeDisplay from Drupal\Tests\localgov_alert_banner\Functional
    2x in AlertBannerBlockTest::testAlertDisplayTitle from Drupal\Tests\localgov_alert_banner\Functional
    2x in AlertBannerBlockTest::testAlertRemoveHideLink from Drupal\Tests\localgov_alert_banner\Functional
    2x in AlertConfirmationTest::testSaveAlertRedirect from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testAlertBannerDisplays from Drupal\Tests\localgov_alert_banner\Functional
    1x in VisibilityTest::testAlertBannerVisibility from Drupal\Tests\localgov_alert_banner\Functional

  27x: Calling the Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch() method with a string event name as the first argument is deprecated in drupal:9.1.0, an Event object will be required instead in drupal:10.0.0. See https://www.drupal.org/node/3154407
    25x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript
    2x in SchedulingTest::testAlertBannerScheduling from Drupal\Tests\localgov_alert_banner\Kernel

  16x: Adding non-existent permissions to a role is deprecated in drupal:9.3.0 and triggers a runtime exception before drupal:10.0.0. The incorrect permissions are "use localgov_alert_banners transition publish", "use localgov_alert_banners transition unpublish". Permissions should be defined in a permissions.yml file or a permission callback. See https://www.drupal.org/node/3193348
    1x in AdminViewTest::testLoadAdminView from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testAlertBannerDisplays from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testNonLiveAlertBannerDoesNotDisplay from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testAlertDisplayTitle from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testAlertRemoveHideLink from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerBlockTest::testAlertBannerTypeDisplay from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertConfirmationTest::testAlertConfirmation from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertConfirmationTest::testSaveAlertRedirect from Drupal\Tests\localgov_alert_banner\Functional
    1x in PermissionsTest::testAlertBannerUserAccess from Drupal\Tests\localgov_alert_banner\Functional
    1x in ViewsStatusLinkTest::testEntityLink from Drupal\Tests\localgov_alert_banner\Functional
    1x in VisibilityTest::testAlertBannerVisibility from Drupal\Tests\localgov_alert_banner\Functional
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript
    1x in AlertBannerBlockOrderTest::testAlertBannerBlockOrder from Drupal\Tests\localgov_alert_banner\Kernel
    1x in SchedulingInstallTest::testEnableScheduledTransitions from Drupal\Tests\localgov_alert_banner\Kernel
    1x in SchedulingInstallTest::testEnableLocalGovAlertBanner from Drupal\Tests\localgov_alert_banner\Kernel
    1x in SchedulingTest::testAlertBannerScheduling from Drupal\Tests\localgov_alert_banner\Kernel

  9x: Javascript Deprecation: jQuery.cookie() is deprecated in Drupal 9.0.0 and will be removed in Drupal 10.0.0. Use the core/js-cookie library instead. See https://www.drupal.org/node/3104677
    9x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  2x: \Drupal\node\Plugin\Condition\NodeType is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\Core\Entity\Plugin\Condition\EntityBundle instead. See https://www.drupal.org/node/2983299
    2x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  2x: The 'condition.plugin.node_type' config schema is deprecated in drupal:9.3.0 and is removed from drupal 10.0.0. Use the 'entity_bundle:node_type' key instead to define a node type condition. See https://www.drupal.org/node/2983299.
    2x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  1x: Adding non-existent permissions to a role is deprecated in drupal:9.3.0 and triggers a runtime exception before drupal:10.0.0. The incorrect permissions are "use text format wysiwyg". Permissions should be defined in a permissions.yml file or a permission callback. See https://www.drupal.org/node/3193348
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  1x: Adding non-existent permissions to a role is deprecated in drupal:9.3.0 and triggers a runtime exception before drupal:10.0.0. The incorrect permissions are "access page_components entity browser pages", "access paragraphs_library_items entity browser pages", "create document media", "create image media", "create localgov_services_landing content", "create localgov_services_page content", "create localgov_services_sublanding content", "create paragraph library item", "create remote_video media", "delete own document media", "delete own image media", "delete own localgov_services_landing content", "delete own localgov_services_page content", "delete own localgov_services_sublanding content", "delete own remote_video media", "edit any document media", "edit any image media", "edit any remote_video media", "edit own document media", "edit own image media", "edit own localgov_services_landing content", "edit own localgov_services_page content", "edit own localgov_services_sublanding content", "edit own remote_video media", "edit paragraph library item", "revert localgov_services_landing revisions", "revert localgov_services_page revisions", "revert localgov_services_sublanding revisions", "view localgov_services_landing revisions", "view localgov_services_page revisions", "view localgov_services_sublanding revisions". Permissions should be defined in a permissions.yml file or a permission callback. See https://www.drupal.org/node/3193348
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  1x: Adding non-existent permissions to a role is deprecated in drupal:9.3.0 and triggers a runtime exception before drupal:10.0.0. The incorrect permissions are "access page_components entity browser pages", "access paragraphs_library_items entity browser pages", "create document media", "create image media", "create localgov_services_landing content", "create localgov_services_page content", "create localgov_services_sublanding content", "create paragraph library item", "create remote_video media", "delete own document media", "delete own image media", "delete own localgov_services_landing content", "delete own localgov_services_page content", "delete own localgov_services_sublanding content", "delete own remote_video media", "edit any document media", "edit any image media", "edit any remote_video media", "edit own document media", "edit own image media", "edit own localgov_services_landing content", "edit own localgov_services_page content", "edit own localgov_services_sublanding content", "edit own remote_video media", "edit paragraph library item", "view localgov_services_landing revisions", "view localgov_services_page revisions", "view localgov_services_sublanding revisions". Permissions should be defined in a permissions.yml file or a permission callback. See https://www.drupal.org/node/3193348
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  1x: Adding non-existent permissions to a role is deprecated in drupal:9.3.0 and triggers a runtime exception before drupal:10.0.0. The incorrect permissions are "access page_components entity browser pages", "access paragraphs_library_items entity browser pages", "create document media", "create image media", "create localgov_services_landing content", "create localgov_services_page content", "create localgov_services_sublanding content", "create paragraph library item", "create remote_video media", "delete any document media", "delete any image media", "delete any localgov_services_landing content", "delete any localgov_services_page content", "delete any localgov_services_sublanding content", "delete any remote_video media", "delete localgov_services_landing revisions", "delete localgov_services_page revisions", "delete localgov_services_sublanding revisions", "delete own document media", "delete own image media", "delete own localgov_services_landing content", "delete own localgov_services_page content", "delete own localgov_services_sublanding content", "delete own remote_video media", "edit any document media", "edit any image media", "edit any localgov_services_landing content", "edit any localgov_services_page content", "edit any localgov_services_sublanding content", "edit any remote_video media", "edit own document media", "edit own image media", "edit own localgov_services_landing content", "edit own localgov_services_page content", "edit own localgov_services_sublanding content", "edit own remote_video media", "edit paragraph library item", "revert localgov_services_landing revisions", "revert localgov_services_page revisions", "revert localgov_services_sublanding revisions", "view localgov_services_landing revisions", "view localgov_services_page revisions", "view localgov_services_sublanding revisions". Permissions should be defined in a permissions.yml file or a permission callback. See https://www.drupal.org/node/3193348
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript

  1x: Drupal\Core\Plugin\ContextAwarePluginBase is deprecated in drupal:9.1.0 and will be removed before drupal:10.0.0. Instead, use \Drupal\Core\Plugin\ContextAwarePluginTrait. See https://www.drupal.org/node/3120980
    1x in AlertBannerHideTest::testAlertBannerHide from Drupal\Tests\localgov_alert_banner\FunctionalJavascript
andybroomfield commented 1 year ago

Does this still happen or is this complete?