Closed stephen-cox closed 2 years ago
Discussion on https://www.drupal.org/node/2491057 is unclear whether we should proceed, however I've opened up a new PR in an attempt to address this since the core class does exist.
Trying to understand the issue, is it that we should remove and just use the generic ContentEntityDeleteForm instead of extending it? As we don't override anything. Looking at localgov_geo for how it handles entity deletion, it does not include its own entity delete form. I think that is the better method to use.
We need to upgrade phpstan to 1.x for PHP 8.1. This highlights the following issues: