localgovdrupal / localgov_alert_banner

Alert banner module for LocalGovDrupal
GNU General Public License v2.0
4 stars 8 forks source link

Fix todos in admin view functional test #370

Closed alansaun92 closed 1 month ago

alansaun92 commented 1 month ago

I noticed a couple of todos mentioned in the functional test AdminViewTest.

So I have moved the creation of the admin user into the setup function and added in a kernel test to confirm that the admin url that we are expecting is the one set on the manage alert banners view.

andybroomfield commented 1 month ago

@ekes, though the new admin view url is a kernel test so should be quicker (the AdminViewTest is a functional test). If we wanted to keep it there we could add the code to the method?

ekes commented 1 month ago

@ekes, though the new admin view url is a kernel test so should be quicker (the AdminViewTest is a functional test). If we wanted to keep it there we could add the code to the method?

I'd overlooked it was a Kernel test.

All good.