andybroomfield
commented
4 years ago Current issues after running lando phix
FILE: ...dules/contrib/localgov_alert_banner/localgov_alert_banner.module
----------------------------------------------------------------------
FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
29 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
40 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
67 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
77 | WARNING | Unused variable $cookie.
92 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
99 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
127 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
192 | WARNING | Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
194 | ERROR | localgov_alert_banner_uninstall() is an installation
| | hook and must be declared in an install file
----------------------------------------------------------------------
FILE: ...algov_alert_banner/tests/src/Functional/AlertBannerBlockTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
32 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------
FILE: ...les/contrib/localgov_alert_banner/localgov_alert_banner.page.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
24 | WARNING | Unused variable $localgov_alert_banner.
----------------------------------------------------------------------
FILE: ...localgov_alert_banner/src/Form/AlertBannerRevisionRevertForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
111 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
----------------------------------------------------------------------
FILE: ...localgov_alert_banner/src/Form/AlertBannerRevisionDeleteForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
95 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
----------------------------------------------------------------------
FILE: ...localgov_alert_banner/src/Access/AlertBannerEntityPageAccess.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
9 | ERROR | Doc comment is empty
14 | ERROR | Doc comment is empty
----------------------------------------------------------------------
FILE: ...modules/contrib/localgov_alert_banner/src/Entity/AlertBanner.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
204 | WARNING | Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
317 | WARNING | Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
----------------------------------------------------------------------
FILE: ...b/modules/contrib/localgov_alert_banner/src/AlertBannerState.php
----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
----------------------------------------------------------------------
15 | ERROR | Missing short description in doc comment
20 | ERROR | Missing short description in doc comment
28 | ERROR | Missing parameter comment
35 | ERROR | Missing short description in doc comment
36 | ERROR | Missing parameter comment
47 | ERROR | Missing short description in doc comment
48 | ERROR | Description for the @return value is missing
54 | ERROR | Missing short description in doc comment
55 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------
FILE: ...ocalgov_alert_banner/src/EventSubscriber/AlertBannerFlagLive.php
----------------------------------------------------------------------
FOUND 5 ERRORS AND 7 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
10 | ERROR | Doc comment is empty
18 | ERROR | Missing parameter comment
23 | WARNING | Unused variable $entityId.
29 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
38 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
49 | ERROR | Parameter comment must start with a capital letter
51 | ERROR | Description for the @return value must be on the next
| | line
55 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
65 | WARNING | Line exceeds 80 characters; contains 81 characters
67 | ERROR | Missing parameter comment
73 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
79 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------
Results from running phpcs