search

localgovdrupal / localgov_alert_banner

Alert banner module for LocalGovDrupal
GNU General Public License v2.0
4 stars 8 forks source link

Suggestion: only regenerate the token if it's a new revision #66

Open ekes opened 4 years ago

ekes commented 4 years ago

At the moment every time it's save it regenerates the token for the cookie to hide. This could be changed to only change on a new revision?

danchamp commented 4 years ago

That makes sense, it's then an editorial decision whether it redisplays to anyone who has already hidden it, rather than a system decision.

andybroomfield commented 4 years ago

Sounds good, I think though we should default to create a new revision in that case, as if theres an update its usually being done in an emergency, and the user story is that when new information is available, the banner is represented.

andybroomfield commented 3 years ago

Tagging as good first issue, may be a little complicated however hopefully something people can get stuck in.