localgovdrupal / localgov_base

The base theme for LocalGov Drupal websites.
8 stars 14 forks source link

Pink background on unpublished pages viewed through preview links #487

Open Adnan-cds opened 11 months ago

Adnan-cds commented 11 months ago

464 has brought back pink backgrounds to unpublished pages. Problem is, when such pages are shared using preview links from the "Preview Link" tab of a page, the pink background is causing confusion among recipients. People are wondering if the pink background is going to stick when the page is published later. Sample screenshot from an unpublished Guide page shared through a preview link:

screenshot-preview-link-page-pink-bg

Copying @DavidBAsch @finnlewis @markconroy @msayoung

willguv commented 11 months ago

@Adnan-cds thanks for flagging. Are you going to propose a fix for this?

I wonder (copying @stephen-cox) if this is related to the preview link issue where content designers have to share multiple links to with service contacts to get content checked.

If we were to have a "Service contact" read only user, we could remove the pink background for them.

What do you both think?

DavidBAsch commented 11 months ago

@willguv To be honest I don't like it at all. I find it difficult to visualise the content when editing, as well as sending to the service when it's displayed like this.

Adnan-cds commented 11 months ago

Are you going to propose a fix for this?

Sorry, nothing in mind. Mark @markconroy asked me to raise this ticket in Slack. I thought Mark wants to fix it. If Mark is unavailable then we can try asking Chris @cjstevens78.

I wonder if this is related to the https://github.com/localgovdrupal/localgov/issues/600 where content designers have to share multiple links to with service contacts to get content checked.

Not entirely related although this issue is going to affect any previewed page that is still not published.

willguv commented 11 months ago

Thanks @DavidBAsch I must admit this one went through without a lot of discussion. I assumed that it would be something everyone would want - sorry, lesson learned!

I think the next thing we should do is toggle this effect on/ off on a whole site. What do you think? Copying @markconroy as he might be able to do the work

Thanks all

DavidBAsch commented 11 months ago

@willguv It might just be me that doesn't like it, though 🤔

andybroomfield commented 11 months ago

Just to add, this is how we do it at Brighton. I think it's important that we have some indication that a page is unpublished. We could look at donoring this after the Drupal 10 work as it's quite straight forword.

Screenshot 2023-10-10 at 12 29 11 pm
DavidBAsch commented 11 months ago

If the purpose is to make people aware it's still in draft then perhaps something like:

Your service page [DRAFT]

Content .......

Would be better than this:

image

markconroy commented 11 months ago

I really like @andybroomfield's approach. A banner across the top saying "This page is not published ..."

stephen-cox commented 11 months ago

+1 for a banner making it clear the page is unpublished.

DavidBAsch commented 10 months ago

The problem I see (or don't see) with banners is they could easily be obscured by live site banners.

image

andybroomfield commented 10 months ago

Make it in page like a system message?

markconroy commented 10 months ago

We have a new approach to this now based on #495

If anyone wants to create the message banner proposed in this issue as an extra bonus feature, that would be cool.

willguv commented 10 months ago

Maybe the banner is at the very top of the page? It could be an option, same as pink background and appending the word [DRAFT]

Thanks in advance for donating if you do it @andybroomfield - much obliged!

markconroy commented 7 months ago

Any thoughts on how the banner approach might work when the unpublished page is an entity reference/teaser inside another page (which may or may not also be unpublished)?

Adnan-cds commented 7 months ago

If it helps, on Service landing pages and Service sublanding pages, we mark unpublished child pages as "Unpublished". Screenshot follows: image