localgovdrupal / localgov_base

The base theme for LocalGov Drupal websites.
8 stars 14 forks source link

Set default colours for subsites extras #551

Closed markconroy closed 3 months ago

markconroy commented 3 months ago

Closes #550

Default is now:

  1. Background colour of region: accent
  2. Background colour of menu items: white
  3. Colour of menu items text: accent
  4. Border on menu items: white

(Basically, the opposite of what we had.)

Screenshot 2024-05-29 at 15 30 47

=== Thanks to Big Blue Door for sponsoring my time to work on this.

willguv commented 3 months ago

Can you add a screenshot please @markconroy cheers. Thanks for looking at this so quickly

markconroy commented 3 months ago

@willguv screenshot added above just now

finnlewis commented 3 months ago

@willguv would like to discuss the menu items looking like buttons. Potentially want a slightly different approach for subsites extras menus.

willguv commented 3 months ago

@markconroy is it easy to make it look like this out of the box?

https://new.dumgal.gov.uk/gretna-registration-office/your-wedding-ceremony

Screenshot 2024-06-11 at 12 32 21 Screenshot 2024-06-11 at 12 32 28
markconroy commented 3 months ago

@willguv Some updates:

  1. Default state - no background colour on menu links
  2. Hover state - white background, with link underlined
  3. Active trail state - white background, no underline, menu tab merges with white section of page below it

All the variables we created are still there so easy to have any style you want, and some new variables have been created to make this even more flexible.

Default:

Screenshot 2024-06-14 at 09 47 08

Hover:

Screenshot 2024-06-14 at 09 47 20

Active:

Screenshot 2024-06-14 at 09 47 29

willguv commented 3 months ago

That's spot on, thanks @markconroy!