localgovdrupal / localgov_base

The base theme for LocalGov Drupal websites.
8 stars 14 forks source link

Full page alert banner does not cover the full page #580

Closed markconroy closed 1 month ago

markconroy commented 1 month ago

Maybe I'm wrong in what I am expecting, but I thought the full page alert banner would cover the full screen and not let me see the rest of the page until I dismissed it.

What I am seeing in an alert banner placed inside a dialog element, which does take over the page but we can still see everything behind it.

I think we need - at minimum - to add a darker ::backdrop to the alert-banner dialog so the rest of the screen is not so visible.

I think we should also adjust the margin so it's set to auto for this item, so it's placed in the middle of the screen vertically and horizontally.

Here's what I am currently seeing:

Screenshot 2024-08-05 at 14 55 35


Thanks to Big Blue Door for sponsoring my time to work on this.