Open ekes opened 1 month ago
Ah. With the dependency on the localgov profile it should be ok... except I now get! Schema errors... because the new config isn't in the schema.
No. That's there.
It seems it's not related to this module. So I think it's fine. If someone else can verify all the better.
I think it's due to the dependency issue, I got this error running locally
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.
Testing /app/web/themes/contrib/localgov_base
Region Render (Drupal\Tests\block_content\Functional\RegionRender)
☢ Region render with data set 0
✘ Region render with data set 1
┐
├ Drupal\Core\Extension\MissingDependencyException: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.
│
╵ /app/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:176
╵ /app/web/core/includes/install.core.inc:1654
╵ /app/web/core/includes/install.core.inc:695
╵ /app/web/core/includes/install.core.inc:572
╵ /app/web/core/includes/install.core.inc:121
╵ /app/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
╵ /app/web/core/tests/Drupal/Tests/BrowserTestBase.php:570
╵ /app/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
╵ /app/web/themes/contrib/localgov_base/tests/Functional/RegionRenderTest.php:36
╵ /app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
┴
Time: 02:38.494, Memory: 10.00 MB
ERRORS!
Tests: 2, Assertions: 0, Errors: 2, Risky: 1.
You need the branch on https://github.com/localgovdrupal/localgov/pull/741 I was still getting an unrelated error though.
To release 1.7.0 we need to get tests passing.
The theme now depends on a (sub-)module. However theme dependencies modules are not enabled when enabling the theme:
https://www.drupal.org/project/drupal/issues/3100374
Adding the module to the
$modules
to be enabled also does not work.I'm going to guess we need to write a
setUp
that enables the module, and then enables the theme.