localgovdrupal / localgov_campaigns

⛔️ DEPRECATED (Provides campaign sections using page builder paragraph types for LocalGov Drupal.)
GNU General Public License v2.0
0 stars 2 forks source link

Add 'Highlighted' paragraph type #39

Closed gosia-mlynarczyk closed 1 year ago

gosia-mlynarczyk commented 4 years ago

Fields:

Relates to 'Add Bracknell campaign paragraphs' issue

willguv commented 4 years ago

David Hampton suggests font awesome, free or pro

@cjstevens78 font awesome is loaded into the LGD default theme

@stephen-cox we're loading in FA elsewhere, needs some kind of config to limit the choice of icons (do later)

Content designer inputs FA code, use the auto complete functionality that already exists

@Adnan-cds can give details

andybroomfield commented 4 years ago

@willguv @gosia-mlynarczyk Assume it will have to be Font-awesome free as we cannot assume if councils will each have a font awesome pro license so we should make the classes match the free versions for anything distributed.

gosia-mlynarczyk commented 4 years ago

@willguv @andybroomfield @stephen-cox @Adnan-cds The Bracknell site actually uses a different font set called IcoMoon, so not sure how to proceed with this one. Maybe it doesn't make sense to include this paragraph type in the LocalGov Campaign paragraphs module, as it's quite tied to a theme (and different themes may use different icons)?

Adnan-cds commented 4 years ago

Hi Gosia, have you considered adding IcoMoon as an Asset library into the Drupal module for this Paragraph?

FAO @gosia-mlynarczyk

stephen-cox commented 4 years ago

Some LocalGov paragraphs are tied to FontAwesome and it's now a dependency of the the core paragraphs module [1]. If we want to allow the selection of different icon libraries then we should construct paragraph types to be agnostic about the particular icon library and add the dependency to the theme. If this is something we would like/need to do then we will need to break the current dependencies and implement icon selection in a generic manner.

keelanfh commented 1 year ago

Closed as module deprecated. If we want to add things into subsites, I think it's more appropriate to create a new issue.