search

localgovdrupal / localgov_campaigns

⛔️ DEPRECATED (Provides campaign sections using page builder paragraph types for LocalGov Drupal.)
GNU General Public License v2.0
0 stars 2 forks source link

Added tabs and tab panel paragraphs #59

Closed gosia-mlynarczyk closed 4 years ago

gosia-mlynarczyk commented 4 years ago

Relates to: Add Tabs paragraph

I've added 2 new paragraphs (Tabs and its child paragraph Tab panel). I've also made some changes to the Accordion paragraph's script, as the Tabs component can be displayed as an Accordion on smaller devices (that's how it currently works on the Bracknell site).

finnlewis commented 4 years ago

Hey @gosia-mlynarczyk The tests pass, but it looks like there are conflicting files on this pull reuqest. Could you review?

gosia-mlynarczyk commented 4 years ago

Thanks @finnlewis , that's done now.

finnlewis commented 4 years ago

I've tested this locally and the tabs paragraph works well.

All the tests pass and no merge conflicts.

The keyboard navigation is neat, so I'm guessing this is functionality that has been tested elsehwere for accessibility @gosia-mlynarczyk , is that right?

Perhaps one quick review of the javascript from another developer:

@andybroomfield @stephen-cox @Adnan-cds any of you want to just confirm you're happy with the JS?

https://github.com/localgovdrupal/localgov_campaigns/pull/59/files?file-filters%5B%5D=.js#diff-5dd7a8947cbc1cc5b4521aea4295220f https://github.com/localgovdrupal/localgov_campaigns/pull/59/files?file-filters%5B%5D=.js#diff-dcc1af500ab29eeb4a2f7f47541480d7

Adnan-cds commented 4 years ago

any of you want to just confirm you're happy with the JS?

Hi Finn, Gosia, JS code looks mostly okay. I have added several comments. I must say I haven't tested the code in a browser.

FAO @finnlewis @gosia-mlynarczyk

gosia-mlynarczyk commented 4 years ago

Thanks @Adnan-cds !