search

localgovdrupal / localgov_campaigns

⛔️ DEPRECATED (Provides campaign sections using page builder paragraph types for LocalGov Drupal.)
GNU General Public License v2.0
0 stars 2 forks source link

Added 3 new fields to Call out box paragraph #66

Closed gosia-mlynarczyk closed 4 years ago

gosia-mlynarczyk commented 4 years ago

Ah yes, I haven't done git pull in the localgov_theme since I've started, so it was working for me.

Should I merge this in, and then create a separate pull request in the localgov_theme repo to update the theme template? What do you think @Adnan-cds @finnlewis @cjstevens78 ?

cjstevens78 commented 4 years ago

Ah yes, I haven't done git pull in the localgov_theme since I've started, so it was working for me.

Should I merge this in, and then create a separate pull request in the localgov_theme repo to update the theme template? What do you think @Adnan-cds @finnlewis @cjstevens78 ?

@gosia-mlynarczyk yes i think this is the best approach, if you mark me as a reviewer on that ill make sure everything's ok on the theme side. I recently made some changes to the call out boxes mainly around how the images are displayed - which required the creation of the theme template file.

Adnan-cds commented 4 years ago

Should I merge this in, and then create a separate pull request in the localgov_theme repo to update the theme template?

That would be very kind of you.

Please note that all the automated test runs are failing at the moment. This is possibly due to a new release of phpstan/phpstan. Changes from this pull request shouldn't break any test, so this one is okay to merge.