localgovdrupal / localgov_core

LocalGovDrupal Core module, for helper functions and core dependencies.
GNU General Public License v2.0
3 stars 6 forks source link

Add text format with CKeditor #12

Closed stephen-cox closed 4 years ago

stephen-cox commented 4 years ago

At the moment there's only plaintext editing. People will want to use CKEditor.

What buttons do we want to include by default? Do we want to include an optional dependency to localgov_media with an entity browser for inserting media as part of this issue?

stephen-cox commented 4 years ago

@ekes @finnlewis Just looking at implementing a CKEditor text format. It's not immediately obvious where it should live. If we put it in core then it will be enabled for any site that uses a localgov component, given they will already have their own text formats this is desirable. Other options are to create a module specifically for this, which seems overkill to me, or to add it to media, which is not necessarily the most obvious place.

Any thoughts? My inclination is to add this to media as it will simplify things when adding a media browser button to CKEditor.

Another question is what buttons we want in CKEditor, my thinking is to add a bunch of defaults taken largely from what Croydon do and then we can review.

stephen-cox commented 4 years ago

A quick review of other distributions show that there are a number of different ways:

stephen-cox commented 4 years ago

From our discussions at standup I will add this to the media module for now as it will be easy enough to move to it's own module later on.