search

localgovdrupal / localgov_core

LocalGovDrupal Core module, for helper functions and core dependencies.
GNU General Public License v2.0
3 stars 6 forks source link

Fix code depreactions for phpstan 1.x (required for PHP 8.1) #126

Closed stephen-cox closed 2 years ago

stephen-cox commented 2 years ago

We need to upgrade phpstan to 1.x for PHP 8.1. This highlights the following issues:

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_core/src/FieldRenameHelper.php                                                      
 ------ ------------------------------------------------------------------------------------------------------------- 
  92     Call to deprecated method findConfigEntityDependentsAsEntities() of class Drupal\Core\Config\ConfigManager:  
         in drupal:9.3.0 and is removed from drupal:10.0.0.                                                           
           Instead you should use                                                                                     
           ConfigManagerInterface::findConfigEntityDependenciesAsEntities().                                          
 ------ -------------------------------------------------------------------------------------------------------------
andybroomfield commented 2 years ago

Wonder if fieldrenamehelper can be dropped now?

stephen-cox commented 2 years ago

Wonder if fieldrenamehelper can be dropped now?

If it's no longer required then we should consider this, although the fix here is so simple I have done that for now #128