localgovdrupal / localgov_directories

Searchable, filterable, directories of information, and locations.
1 stars 3 forks source link

Fix code depreactions for phpstan 1.x (required for PHP 8.1) #181

Closed stephen-cox closed 2 years ago

stephen-cox commented 2 years ago

We need to upgrade phpstan to 1.x for PHP 8.1. This highlights the following issues:

 ------ --------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_directories/modules/localgov_directories_or/tests/src/Kernel/FacetSyncTest.php  
 ------ --------------------------------------------------------------------------------------------------------- 
  70     Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  82     Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  88     Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  94     Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  105    Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  118    Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
  125    Missing explicit access check on entity query.                                                           
         💡 See https://www.drupal.org/node/3201242                                                               
 ------ --------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_directories/src/LocalgovDirectoriesFacetsListBuilder.php  
 ------ ----------------------------------------------------------------------------------- 
  92     Missing explicit access check on entity query.                                     
         💡 See https://www.drupal.org/node/3201242                                         
 ------ ----------------------------------------------------------------------------------- 
stephen-cox commented 2 years ago

Fixed with #182