Enquires address field inconsistent defaults between page and promo page

localgovdrupal / localgov_directories

Searchable, filterable, directories of information, and locations.

1 stars 3 forks source link

Enquires address field inconsistent defaults between page and promo page #237

Open msayoung opened 2 years ago

msayoung commented 2 years ago

Because the address country defaults to the UK, this prints the Enquiry address even if we haven't entered one.

Options

don't set the default country
make this field required.
do some magic in localgov_base to check that more than the country is entered before we print it.

thoughts?

cc @markconroy

markconroy commented 2 years ago

I've just been telling people to set that field to empty if they mean for it to be empty.

Not having a default would fix it.

ekes commented 1 year ago

At the moment the page has a default to UK, and promo page doesn't. With venue having it default was a highly requested feature, because of the UX entering them. Given no default makes sense here neither page nor promo page should have a default. But can we set the allowed countries to be just United Kingdom, this makes the drop down just default None and United Kingdom. If you're deploying elsewhere you'd need to change to your country, but at least you don't default to the huge long list of the world?

markconroy commented 1 year ago

I think the allowed countries should be countries where LGD is being used. Currently UK and Ireland.