search

localgovdrupal / localgov_events

Events for LocalGov Drupal.
GNU General Public License v2.0
1 stars 1 forks source link

Add patch for date_recur create occurances for default revision #144

Open andybroomfield opened 7 months ago

andybroomfield commented 7 months ago

Fix #143

Adds the patch from https://www.drupal.org/project/date_recur/issues/3010184#comment-13156851 (comment 6).

This allows events that have been published to be moved to draft or review and still show on the events calendar, as the default (published) revision will retian it's calculated dates used by views.

andybroomfield commented 7 months ago

Patch is being used at BHCC, so will let you know how it goes. Initial testing shows this works.

andybroomfield commented 7 months ago

This is working for us, new drafts and reviews arn't removing the event from the listing.

ekes commented 7 months ago

Just checking: the intention here is to calculate and store the future occurrences of the recur field on both the latest (unpublished) revision and the (published) current revision.

andybroomfield commented 7 months ago

From what I gather yes that is correct, as this is to prevent interference with the existing set up and tests, so that dates are generated for the current revision and the latest (unpublished) revision.

andybroomfield commented 4 months ago

Do we want to move forward with this. Currently if an event goes to a new draft or review it will fall of the list. New events work does also resolve, but that requires the switch to search api which maybe not everyone will go with straight away.

finnlewis commented 3 months ago

@ekes any more thoughts on this?

andybroomfield commented 2 months ago

This is possibly redundant with the search api work, but if your using the existing view you need the patch else if you make a new revision events do disappear.