localgovdrupal / localgov_events

Events for LocalGov Drupal.
GNU General Public License v2.0
1 stars 0 forks source link

Events in the past visible by default when applying filters #58

Open andybroomfield opened 2 years ago

andybroomfield commented 2 years ago

Unless searched for a date range, events in the past should not be visible in the events view.

andybroomfield commented 2 years ago

I see that when going to /events the default of the filter is today in the view, but not shown in the exposed filter as it is a different format. I am however seeing only events in the future on the initial load.

However if I then apply any filter (changing price from all to free or paid) then I see all events in the past, as the default date filter is not carried forward.

Can others who use Events (Lambeth @finnlewis and Croydon @Adnan-cds) confirm if this happens on their versions with the more vanilla filters.

andybroomfield commented 2 years ago

See also #12

Adnan-cds commented 2 years ago

Can others who use Events (Lambeth @finnlewis and Croydon @Adnan-cds) confirm if this happens on their versions with the more vanilla filters.

Sorry Andy, we are not using localgov_events yet :(

finnlewis commented 2 years ago

Just to confirm, this is demostratable on the demo site.

https://demo.localgovdrupal.org/events?neighbourhood=All&price=All&category=All&dates=choose&start=&end=

finnlewis commented 2 years ago

Can we try setting the start date explosed filter to default to today, such that if we submit the form, we are still filtering on events that start in the future?

finnlewis commented 2 years ago

@andybroomfield is working on this at the moment.