search

localgovdrupal / localgov_events

Events for LocalGov Drupal.
GNU General Public License v2.0
1 stars 0 forks source link

Initial events functionality. #7

Closed stephen-cox closed 3 years ago

stephen-cox commented 3 years ago

Events! For a full spec see: https://github.com/localgovdrupal/localgov/issues/136

To test this you can install the module with:

composer require localgovdrupal/localgov_events:dev-develop

To test the venue / location stuff you'll need to enable localgov_directories_venues as well.

Closes #1 Closes #2 Closes #3 Closes #4 Closes #5

stephen-cox commented 3 years ago

There are still some bugs to fix, but the main functionality is working, so creating a pull request so people can start reviewing code as my time runs out on this in a couple of days time.

finnlewis commented 3 years ago

I've not reviewed the code, but I've tested the functionality and it all works well.

The only suggestion for improvement I currently have is to have a default date set to now when creating an event. I find that makes it sighlty quicker and more intuitive to set a new date and time.

finnlewis commented 3 years ago

@Adnan-cds @andybroomfield it would be really good to get this to a point where we're happy to merge what is working and file other bugs / UX change requests as separate issues. Do you think we're nearly there? @stephen-cox has been working on it today, so if either of you have a chance to finalise your reviews and approve before tomorrow morning, that would be most excellent.

Of course, if there is something blocking, then there is! But it would be good to be able to demo this tomorrow.

stephen-cox commented 3 years ago

All the major issues found here https://github.com/localgovdrupal/localgov/issues/136#issuecomment-704132711 should now be fixed. I'll raise another pull request to add this to the profile.

finnlewis commented 3 years ago

Tests pass @stephen-cox @Adnan-cds @andybroomfield ! So the updated composer shenanigans seems to work @Adnan-cds, and the code hasn't broken anything that we're testing @stephen-cox, which is nice.

finnlewis commented 3 years ago

We're going to nee a bit more front end love on the events (and directories for that matter), but as most people who are using this have their own theme, that is mainly a marketing / shop window issue. Maybe next sprint we can have a presentation clean up.