search

localgovdrupal / localgov_events

Events for LocalGov Drupal.
GNU General Public License v2.0
1 stars 0 forks source link

Events thumbnail Image updated with "hidden" label #94

Closed bisd closed 1 year ago

bisd commented 1 year ago

This is an extension of https://github.com/localgovdrupal/localgov_core/issues/165. The labels for some of the image formats were marked "Visually hidden" which was unnecessary and can all be set to "Hidden".

bisd commented 1 year ago

I am wondering whether or not to withdraw the pull request I have made for this issue as the image label was set to Hidden anyway? The only difference in the new file is that it has added a "lazy" image loading attribute. As this file is in the "Install" folder, there may be a case for not changing the other default settings like the image loading attribute - not sure.

Pull request https://github.com/localgovdrupal/localgov_events/pull/95

bisd commented 1 year ago

I have closed the pull request and deleted the branch for it. The reason for creating the issue and editing the file in this repo was to change the label for the "core.entity_view_display.media.image.localgov_event_thumbnail.yml" file. But the setting for this file is already set to "hidden" so there does not seem to be any achievable purpose in editing the file. Therefore I am closing the issue as well.