localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

Update aborted by: localgov_geo_update_update_8807 #101

Closed rgcarr closed 10 months ago

rgcarr commented 10 months ago

I'm trying to update a site to D10. All going well until I got the Update aborted by: localgov_geo_update_update_8807 during DB updates. No other errors reported in log, so not sure why this problem occurs

Update 8807 updates Views fields: https://github.com/localgovdrupal/localgov_geo/blob/f4bbb2c4f52cc96e72a7c7344c13a003f67177b1/modules/localgov_geo_update/localgov_geo_update.install#L239C1-L269C2

Not even sure if it's vaguely connected, but in (https://github.com/localgovdrupal/localgov_geo/blob/2.x/localgov_geo.install) there is:

function localgov_geo_update_last_removed() {
  // Removed all pre-Drupal 10 hooks that updated things now in geo_entity.
  return 8810;
}

Has this been seen elsewhere, or is there an obvious place to start looking?

ekes commented 10 months ago

I'm assuming if localgov_geo_update is enabled all updates for 9.x had been run before starting the D10 update?

Is there really no [error] line in the updb output before Update aborted by? Can you post the full output of the update?

andybroomfield commented 10 months ago

Possibly daft question @rgcarr but do you have any views that reference localgov_geo, like directories? We did find a couple that didn't get updated properly, but those where our custom ones so assumed it was our issue and a search and replace and reimport of the config sorted it.

ekes commented 10 months ago

Also I realize (as I'm just debugging a completely unrelated, like completely Thunder not LGD site) that when something like this fails you can keep re-running it, as it'll pick up from this error and try the update again. So if you've not got an error message you can probably re-run it now and get one.

If there's not... are you up for any debugging? Like anything from setting breakpoints, to just adding 'print 1;' 'print 2;' lines into the update hook to see where it stops?

rgcarr commented 10 months ago

Re-ran the whole update and had an error above the aborted message: No entity type for field location on view geo_list This was a custom admin view to list all the Geo entities under 'Content'. Clearly things have changed with the D10 module although not sure how, as Geo entities are present in D10...

DB update ran fine once the View was deleted.

rgcarr commented 10 months ago

Thanks everyone for your help

rgcarr commented 10 months ago

FYI - ran DB update 4 times before the helpful error message appeared.

ekes commented 10 months ago

I suppose us incidentally highlighting views that aren't completely updated isn't a bad thing. If we can't autofix these too (could we?), we should write another line for the upgrade howto.

ekes commented 10 months ago

@andybroomfield Can you remember is it throwing an exception. That'd be my assumption if it's stopping? We could catch that and set a message in the upgrade about viewname needing manual check if that's the case?

andybroomfield commented 10 months ago

@ekes I don't think it did for us, update ran smoothly but then we had to update the view as we got error 500's when viewing the page with that view on it.

andybroomfield commented 10 months ago

This is the view (pre update)

uuid: cee08cf4-70f6-4317-9ae1-7f27d2e136b0
langcode: en
status: true
dependencies:
  config:
    - field.storage.localgov_geo.bhcc_zone_details
    - field.storage.localgov_geo.bhcc_zone_id
    - field.storage.localgov_geo.location
    - localgov_geo.localgov_geo_type.parking_zone
  module:
    - geofield
    - leaflet_views
    - localgov_geo
    - text
    - user
_core:
  default_config_hash: PGnN2DnvnpZW94bHz3Ygrg8fnrV5Q33wYOmuRTOREmo
id: parking_zones_map
label: 'Parking zones map'
module: views
description: ''
tag: ''
base_table: localgov_geo_field_data
base_field: id
display:
  default:
    id: default
    display_title: Default
    display_plugin: default
    position: 0
    display_options:
      title: 'Find your parking zone and buy permits'
      fields:
        label:
          id: label
          table: localgov_geo_field_data
          field: label
          relationship: none
          group_type: group
          admin_label: ''
          entity_type: null
          entity_field: label
          plugin_id: field
          label: ''
          exclude: true
          alter:
            alter_text: false
            text: ''
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: true
          click_sort_column: value
          type: string
          settings:
            link_to_entity: false
          group_column: value
          group_columns: {  }
          group_rows: true
          delta_limit: 0
          delta_offset: 0
          delta_reversed: false
          delta_first_last: false
          multi_type: separator
          separator: ', '
          field_api_classes: false
        location:
          id: location
          table: localgov_geo__location
          field: location
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: field
          label: ''
          exclude: true
          alter:
            alter_text: false
            text: ''
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: true
          click_sort_column: value
          type: geofield_default
          settings:
            output_format: wkt
            output_escape: true
          group_column: value
          group_columns: {  }
          group_rows: true
          delta_limit: 0
          delta_offset: 0
          delta_reversed: false
          delta_first_last: false
          multi_type: separator
          separator: ', '
          field_api_classes: false
        bhcc_zone_id:
          id: bhcc_zone_id
          table: localgov_geo__bhcc_zone_id
          field: bhcc_zone_id
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: field
          label: ''
          exclude: true
          alter:
            alter_text: false
            text: ''
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: true
          click_sort_column: value
          type: string
          settings:
            link_to_entity: false
          group_column: value
          group_columns: {  }
          group_rows: true
          delta_limit: 0
          delta_offset: 0
          delta_reversed: false
          delta_first_last: false
          multi_type: separator
          separator: ', '
          field_api_classes: false
        bhcc_zone_details:
          id: bhcc_zone_details
          table: localgov_geo__bhcc_zone_details
          field: bhcc_zone_details
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: field
          label: ''
          exclude: false
          alter:
            alter_text: false
            text: ''
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: true
          click_sort_column: value
          type: text_default
          settings: {  }
          group_column: value
          group_columns: {  }
          group_rows: true
          delta_limit: 0
          delta_offset: 0
          delta_reversed: false
          delta_first_last: false
          multi_type: separator
          separator: ', '
          field_api_classes: false
        nothing:
          id: nothing
          table: views
          field: nothing
          relationship: none
          group_type: group
          admin_label: 'Map description'
          plugin_id: custom
          label: ''
          exclude: true
          alter:
            alter_text: true
            text: "<div class=\"padding-small padding-bottom-x-small\">\r\n<span class=\"block margin-bottom-small weight-bold text:upper\">{{ label }}</span>\r\n<p><a href=\"/parking-zones?field_zone_id_value={{ bhcc_zone_id }}#map\">Full details</a></p>\r\n</div>"
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: false
        nothing_1:
          id: nothing_1
          table: views
          field: nothing
          relationship: none
          group_type: group
          admin_label: 'Map label'
          plugin_id: custom
          label: ''
          exclude: true
          alter:
            alter_text: true
            text: 'Zone {{ bhcc_zone_id }}'
            make_link: false
            path: ''
            absolute: false
            external: false
            replace_spaces: false
            path_case: none
            trim_whitespace: false
            alt: ''
            rel: ''
            link_class: ''
            prefix: ''
            suffix: ''
            target: ''
            nl2br: false
            max_length: 0
            word_boundary: true
            ellipsis: true
            more_link: false
            more_link_text: ''
            more_link_path: ''
            strip_tags: false
            trim: false
            preserve_tags: ''
            html: false
          element_type: ''
          element_class: ''
          element_label_type: ''
          element_label_class: ''
          element_label_colon: false
          element_wrapper_type: ''
          element_wrapper_class: ''
          element_default_classes: true
          empty: ''
          hide_empty: false
          empty_zero: false
          hide_alter_empty: false
      pager:
        type: none
        options:
          offset: 0
          items_per_page: 0
      exposed_form:
        type: basic
        options:
          submit_button: Apply
          reset_button: false
          reset_button_label: Reset
          exposed_sorts_label: 'Sort by'
          expose_sort_order: true
          sort_asc_label: Asc
          sort_desc_label: Desc
      access:
        type: perm
        options:
          perm: 'view geo'
      cache:
        type: tag
        options: {  }
      empty: {  }
      sorts:
        bhcc_zone_id_value:
          id: bhcc_zone_id_value
          table: localgov_geo__bhcc_zone_id
          field: bhcc_zone_id_value
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: standard
          order: ASC
          expose:
            label: ''
            field_identifier: ''
          exposed: false
      arguments: {  }
      filters:
        bundle:
          id: bundle
          table: localgov_geo_field_data
          field: bundle
          entity_type: localgov_geo
          entity_field: bundle
          plugin_id: bundle
          value:
            parking_zone: parking_zone
          expose:
            operator_limit_selection: false
            operator_list: {  }
        bhcc_zone_id_value:
          id: bhcc_zone_id_value
          table: localgov_geo__bhcc_zone_id
          field: bhcc_zone_id_value
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: string
          operator: '='
          value: ''
          group: 1
          exposed: true
          expose:
            operator_id: bhcc_zone_id_value_op
            label: 'Zone ID'
            description: ''
            use_operator: false
            operator: bhcc_zone_id_value_op
            operator_limit_selection: false
            operator_list: {  }
            identifier: field_zone_id_value
            required: false
            remember: false
            multiple: false
            remember_roles:
              authenticated: authenticated
              emergency_publisher: '0'
              anonymous: '0'
              localgov_editor: '0'
              localgov_author: '0'
              localgov_contributor: '0'
              localgov_news_editor: '0'
              localgov_user_manager: '0'
            placeholder: ''
          is_grouped: false
          group_info:
            label: ''
            description: ''
            identifier: ''
            optional: true
            widget: select
            multiple: false
            remember: false
            default_group: All
            default_group_multiple: {  }
            group_items: {  }
      style:
        type: leaflet_map
        options:
          grouping: {  }
          data_source: location
          entity_source: __base_table
          name_field: nothing_1
          view_mode: full
          leaflet_map: 'OSM Mapnik'
          height: '550'
          height_unit: px
          hide_empty_map: true
          disable_wheel: true
          gesture_handling: false
          reset_map:
            control: false
            position: topright
          map_position:
            force: false
            center:
              lat: !!float 0
              lon: !!float 0
            zoom: 13
            minZoom: 13
            maxZoom: 18
            zoomFiner: 0
          weight: ''
          icon:
            iconType: marker
            iconUrl: ''
            shadowUrl: ''
            className: ''
            iconSize:
              x: ''
              'y': ''
            iconAnchor:
              x: ''
              'y': ''
            shadowSize:
              x: ''
              'y': ''
            shadowAnchor:
              x: ''
              'y': ''
            popupAnchor:
              x: ''
              'y': ''
            html: '<div></div>'
            html_class: leaflet-map-divicon
            circle_marker_options: '{"radius":100,"color":"red","fillColor":"#f03","fillOpacity":0.5}'
          path: '{"color":"#ff0000","opacity":"1.0","stroke":true,"weight":2,"fill":"depends","fillColor":"*","fillOpacity":"0","radius":"6","className":"js-parking-zone parking-zone-{{ bhcc_zone_id|striptags|lower }}","label":"{{ nothing_1 }}"}'
          geocoder:
            control: false
            settings:
              position: topright
              input_size: 25
              providers:
                localgov_default_osm:
                  weight: '0'
                  checked: 0
              min_terms: 4
              delay: 800
              zoom: 16
              popup: false
              options: ''
          description_field: nothing
          fullscreen_control: false
      row:
        type: fields
      query:
        type: views_query
        options:
          query_comment: ''
          disable_sql_rewrite: false
          distinct: false
          replica: false
          query_tags: {  }
      relationships: {  }
      use_ajax: true
      header: {  }
      footer: {  }
      display_extenders: {  }
    cache_metadata:
      max-age: -1
      contexts:
        - 'languages:language_content'
        - 'languages:language_interface'
        - url
        - user.permissions
      tags:
        - 'config:field.storage.localgov_geo.bhcc_zone_details'
        - 'config:field.storage.localgov_geo.bhcc_zone_id'
        - 'config:field.storage.localgov_geo.location'
  attachment_1:
    id: attachment_1
    display_title: Attachment
    display_plugin: attachment
    position: 2
    display_options:
      pager:
        type: some
        options:
          offset: 0
          items_per_page: 0
      filters:
        bundle:
          id: bundle
          table: localgov_geo_field_data
          field: bundle
          entity_type: localgov_geo
          entity_field: bundle
          plugin_id: bundle
          value:
            parking_zone: parking_zone
          expose:
            operator_limit_selection: false
            operator_list: {  }
        bhcc_zone_id_value:
          id: bhcc_zone_id_value
          table: localgov_geo__bhcc_zone_id
          field: bhcc_zone_id_value
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: string
          operator: '='
          value: ''
          group: 1
          exposed: true
          expose:
            operator_id: bhcc_zone_id_value_op
            label: 'Zone ID'
            description: ''
            use_operator: false
            operator: bhcc_zone_id_value_op
            operator_limit_selection: false
            operator_list: {  }
            identifier: field_zone_id_value
            required: false
            remember: false
            multiple: false
            remember_roles:
              authenticated: authenticated
              emergency_publisher: '0'
              anonymous: '0'
              localgov_editor: '0'
              localgov_author: '0'
              localgov_contributor: '0'
              localgov_news_editor: '0'
              localgov_user_manager: '0'
            placeholder: ''
          is_grouped: false
          group_info:
            label: ''
            description: ''
            identifier: ''
            optional: true
            widget: select
            multiple: false
            remember: false
            default_group: All
            default_group_multiple: {  }
            group_items: {  }
      filter_groups:
        operator: AND
        groups:
          1: AND
      style:
        type: default
        options:
          grouping: {  }
          row_class: ''
          default_row_class: true
          uses_fields: false
      row:
        type: fields
        options: {  }
      defaults:
        style: false
        row: false
        filters: false
        filter_groups: false
      display_extenders: {  }
      displays:
        page_1: page_1
      attachment_position: after
      inherit_exposed_filters: true
    cache_metadata:
      max-age: -1
      contexts:
        - 'languages:language_content'
        - 'languages:language_interface'
        - url
        - user.permissions
      tags:
        - 'config:field.storage.localgov_geo.bhcc_zone_details'
        - 'config:field.storage.localgov_geo.bhcc_zone_id'
        - 'config:field.storage.localgov_geo.location'
  page_1:
    id: page_1
    display_title: Page
    display_plugin: page
    position: 1
    display_options:
      defaults:
        css_class: false
        header: false
        footer: false
      css_class: 'parking-zone-map-view js-parking-zone-map-view'
      header:
        area:
          id: area
          table: views
          field: area
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: text
          empty: false
          content:
            value: "<a id=\"map\"></a>\r\nTo view our current permit prices please visit our <a href=\"/content/parking-and-travel/parking/resident-permit-charges-2021-22\">permit price page</a>."
            format: editor
          tokenize: false
      footer:
        area:
          id: area
          table: views
          field: area
          relationship: none
          group_type: group
          admin_label: ''
          plugin_id: text
          empty: false
          content:
            value: '<p>Zone borders on this map are approximate. Always check street signs before you park.</p>'
            format: editor
          tokenize: false
      display_extenders: {  }
      path: parking-zones
    cache_metadata:
      max-age: -1
      contexts:
        - 'languages:language_content'
        - 'languages:language_interface'
        - url
        - user.permissions
      tags:
        - 'config:field.storage.localgov_geo.bhcc_zone_details'
        - 'config:field.storage.localgov_geo.bhcc_zone_id'
        - 'config:field.storage.localgov_geo.location'