search

localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

Geocoder version flexibility for upgrades from Drupal 9 to 10 #105

Open finnlewis opened 1 year ago

finnlewis commented 1 year ago

When upgrading from Drupal 9 to Drupal 10, Upgrade Status reports that geocoder is incompatible:

image

I am wondering if allowing multiple versions of geocoder might allow people to update geocoder before updatign to Drupal 10.

So changing the dependency to : 

"drupal/geocoder": "^3.7 || ^4.10",

I realise this is probably a bit late, with Drupal 9 being end of life, but some people are yet to upgrade from Drupal 9.

andybroomfield commented 1 year ago

From composer why on Drupal 10.

$ composer why drupal/geocoder
drupal/geo_entity             1.0.0-beta5 requires drupal/geocoder (^4.4)          
localgovdrupal/localgov_forms 1.0.0-beta2 requires drupal/geocoder (^3.20 || ^4.0)

So when you upgrade and get geo entity, sites will get geocoder 4. Though interestingly localgov_forms can use both.

I thought the problem was that localgov_geo itself is not compatible with geocoder 4 which is why it was initially getting a new release, but then geo_entitiy took over.

ekes commented 1 year ago

I thought the problem was that localgov_geo itself is not compatible with geocoder 4

Reading the code there's little difference between 3 and 4, not quite sure what the backward compatibility break is... but for https://github.com/localgovdrupal/localgov_geo/pull/106#issuecomment-1807724524 which suggests maybe it's Guzzle.