localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

Fix remaining strict types errors #114

Open millnut opened 7 months ago

millnut commented 7 months ago

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_address/tests/Functional/AddressFormsTest.php
 ------ -------------------------------------------------------------------------------------------------
  107    Call to static method Drupal\Component\Utility\Html::escape() with incorrect case: Escape
 ------ -------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/src/MigrateDisplayModes.php
 ------ --------------------------------------------------------------------------------------
  200    Variable $new_config in empty() is never defined.
  201    Undefined variable: $new_config
  224    Variable $new_base_array might not be defined.
  227    Variable $new_base_array might not be defined.
 ------ --------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/tests/modules/localgov_geo_update_to_geo_test/src/Element/AutocompleteAddress.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  75     Variable $url might not be defined.
  76     Variable $url might not be defined.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/tests/modules/localgov_geo_update_to_geo_test/src/Plugin/Field/FieldWidget/AutocompleteAddress.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  255    Parameter #2 $callback of function uasort expects callable(Drupal\Core\Entity\EntityInterface, Drupal\Core\Entity\EntityInterface): int, Closure(Drupal\geocoder\Entity\GeocoderProvider, Drupal\geocoder\Entity\GeocoderProvider): (-1|0|1) given.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------