localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

New missing schema errors #48

Closed ekes closed 2 years ago

ekes commented 2 years ago
Schema key core.entity_view_display.localgov_geo.address.default:content.location.settings.fullscreen_control failed with: missing schema

Repeated for multiple tests, always related to fullscreen_control

ekes commented 2 years ago

It looks like leaflet might have made a (non-backward compatible !) update to the schema:-

https://git.drupalcode.org/project/leaflet/-/commit/636b1b8

First task pin our version to the previous? Then we have time to update all the exported config, and look at what upgrades they have.

ekes commented 2 years ago

https://www.drupal.org/project/leaflet/issues/3252649#comment-14355445

andybroomfield commented 2 years ago

Was just checking this as leaflet pinned to 2.1.16. drupal/leaflet": ">=2.0 <2.1.17", I take it this is the reason, though there are some features in newer version I'd like to use. Any word on when this would be fixed? Is it just default content that needs to be updated?

ekes commented 2 years ago

Yep. It's the configuration that got changed as mentioned on the issue, so all existing config needs updating. This is completely an issue for our default content. For existing sites I think the only issue is flagging up that export content from the db will change with the upgrade. If anyone is configuring full screen I'm not sure the existing config will upgrade either - but haven't tested.

But yes main thing is default content.

finnlewis commented 2 years ago

I'll take a look at this!