search

localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

Remove geofield_map #97

Closed finnlewis closed 10 months ago

finnlewis commented 11 months ago

Try requiring the currently supported branch of geofield_map.

There is at least one test that requires it, so I'm just looking for the simplest way to support PHP 8.2

finnlewis commented 11 months ago

So this seems to work... the tests pass... functionality locally seems good (still not sure if we're actually using geofield_map on the Drupal 10 install?)

Any thoughts @ekes @millnut ?

ekes commented 11 months ago

Geo entity just uses leaflet, not geofield map. So with the default new entity form you have leaflet as the input. It's possible that hasn't been replaced in some installs? Generally geofield map is redundant, and has loads of errors if you don't have a google api key (even if you don't need it), and it has a bug about map placement when the tabs or inline form move position after first render.

andybroomfield commented 11 months ago

It'l be needed if you havn't updated, or you'll get a form error (broken or missing widget). The update will simply copy accross what was there before.

If we don't want to upgrade it to 3.x, we should remove it. We could post that as an advisory? This would allow those that do use is to add it to their own composer.json branch.

finnlewis commented 10 months ago

@ekes just using this pull request to test removing geofield_map completely.

finnlewis commented 10 months ago

@ekes how's this? Tests pass , so hopefully just need to write some release notes and we can merge and tag a release, no?