search

localgovdrupal / localgov_geo

Entity for storing Geographic information, addresses, and areas; extensible types and plugable backends with defaults to start.
2 stars 1 forks source link

Rename 'Geo' to 'Locations' #98

Closed stephen-cox closed 10 months ago

stephen-cox commented 10 months ago

Fixes #86

finnlewis commented 10 months ago

Thanks @stephen-cox , I've tested locally and it seems to do the job.

At : admin/content/geo/add the page title is still "Add geo", so we might want to change that to "Add location"

willguv commented 10 months ago

Thanks for spotting @finnlewis

I should have added all the instances of "Geo" I've seen to the original issue, sorry

Think they are:

Screenshot 2023-10-21 at 17 20 46 Screenshot 2023-10-21 at 17 21 20 Screenshot 2023-10-21 at 17 21 40 Screenshot 2023-10-21 at 17 22 48 Screenshot 2023-10-21 at 17 16 59
finnlewis commented 10 months ago

Sounds like we should add the other string replacements before merging.

Thanks @willguv and @stephen-cox !

stephen-cox commented 10 months ago

@willguv @finnlewis I have updated the PR so geo is changed to location on the add pages and in the breadcrumb.

The 'Geo type' menu items and pages are not accessible to content editors, only site admins, so I'm not sure they need changing, but I can add this if you think it's necessary.

willguv commented 10 months ago

Hi @stephen-cox it would be good to get consistency here - could you add change the 'geo type' things please? Thanks