localgovdrupal / localgov_legacy_migration

Documentation of field and entity changes in the form of Drupal Migration YAML
0 stars 1 forks source link

Migrate metadata, redirects, aliases #16

Open stephen-cox opened 4 years ago

stephen-cox commented 4 years ago

@andybroomfield @Adnan-cds We are not currently using the Redirect or Metatags module in LocalGov Drupal. Would you like migrations for this data? If so, I'll add the modules to localgov_core and then add migrations for them.

Adnan-cds commented 4 years ago

Would you like migrations for this data? If so, I'll add the modules to localgov_core and then add migrations for them.

Yes, please. Can't think of a Drupal site without Redirect and Metatag. In fact you raised a ticket about these early on :)

andybroomfield commented 4 years ago

Hi @stephen-cox, as @Adnan-cds we are quite big users of redirect an meta tag so those will need to come across.

There's actually two redirect modules, the is redirect and a ported drupal 7 module cake url router, though ideally the redirects from that should merge into the redirects table.

Adnan-cds commented 4 years ago

Hi Andy, As far as I remember, this urlrouter module was needed in the early days of Redirect 8.x when it couldn't redirect to external sites. Now that Redirect can redirect to external sites, would you mind reviewing the need for urlrouter.

FAO @andybroomfield

andybroomfield commented 4 years ago

@Adnan-cds oh I meant I would remove url router and migrate its redirects into the redirect module. They'd going to be a bunch in there that need to come across into redirect.

Adnan-cds commented 4 years ago

I meant I would remove url router and migrate its redirects into the redirect module.

Excellent :)

stephen-cox commented 4 years ago

Pull request for URL paths is here: https://github.com/localgovdrupal/localgov_legacy_migration/pull/22

Redirects and and metadata are still do to.

Adnan-cds commented 3 years ago

Hi Andy, Could you please confirm if the BHCC site is using any field of type metatag or not. I cannot find any in the Croydon site. I have checked the field list report from /admin/reports/fields and also programmatically:

drush php:eval "print_r(array_keys(Drupal::service('entity_field.manager')->getFieldMapByFieldType('metatag')['node']));"

The Croydon site has quite a few Metatag config files but I cannot find any metatag field that needs migrating.

FAO @andybroomfield

Adnan-cds commented 3 years ago

Forgot to mention that the metatag field is used to assign metatags per entity whereas the Metatag configs cover the per-bundle scenario.