search

localgovdrupal / localgov_menu_link_group

Present menu links in groups.
0 stars 0 forks source link

Tag 1.0.0 #6

Closed ekes closed 3 years ago

ekes commented 3 years ago

As per localgovdrupal/localgov#194 localgovdrupal/localgov#200

PR/Issue #3 #5 Check not blocking.

ekes commented 3 years ago

@andybroomfield Should we try and get #5 in before tagging? It does expose items to users without permission, but on the other hand it's in admin. Alternatively is there something easy to nudge it along?

andybroomfield commented 3 years ago

@ekes I'd like to get it in if possible, as it does confuse things for users who only have limited permissions. The PR I raised does work from my manual testing, however I am struggling to write the test for it. @Adnan-cds was going to take a look, or if anyone wants to take over. Basically create some menu groups that include only things a user won't have permission for and check the group is excluded.

Adnan-cds commented 3 years ago

Okay, I will have a look at #5 later today. Sorry for holding you back.

Adnan-cds commented 3 years ago

Sorry, got late again. I am looking into #5 now.

ekes commented 3 years ago

So #200 can be round off #5 can go into a 1.0.1 or 1.0.2

ekes commented 3 years ago

https://github.com/localgovdrupal/localgov_menu_link_group/releases/tag/1.0.0