localgovdrupal / localgov_microsites

A repository for the LocalGov Drupal Microsites project.
GNU General Public License v2.0
3 stars 2 forks source link

Site design: footer design #73

Closed finnlewis closed 2 years ago

finnlewis commented 2 years ago

Mark has built out the form.

This has overrides for each colour and header width behaviour.

Todo:

msayoung commented 2 years ago

@finnlewis - having a look at this, I'm not sure I understand what is needed?

(I'm assuming you mean footer when you say header)

finnlewis commented 2 years ago

We created each of these 'site design' issues to spilt out the work to check that the theme responds appropriately to changing values in the configuration.

In this case, I think editing each field that affects the footer, and see how it plays.

We also mentioned the colour picker widget on all colour fields, which was originally an assumption of mine, but on discussion was generally agreed to be a nice thing to have and would not prevent entering other css values into the text field.

msayoung commented 2 years ago

@finnlewis when you say "check language of the footer layout." do you mean the help text ?

finnlewis commented 2 years ago

I'm not sure, possibly how the layout options are described? @markconroy @richard-s-rowley do you recall what we mean by "git@github.com:localgovdrupal/localgov_microsites.git" ?

markconroy commented 2 years ago

I think we meant the specific words we used for the layout options: 'full width', 'full with with content contained', etc

msayoung commented 2 years ago

How about?

msayoung commented 2 years ago

@finnlewis what do you think about the suggestion for the words

markconroy commented 2 years ago

I like those suggestions

finnlewis commented 2 years ago

Sounds great for now, we'll get some feedback from the testing I'm sure,

msayoung commented 2 years ago

PR here for field labels: https://github.com/localgovdrupal/localgov_microsites_group/pull/80