Closed finnlewis closed 2 years ago
@finnlewis - having a look at this, I'm not sure I understand what is needed?
(I'm assuming you mean footer when you say header)
We created each of these 'site design' issues to spilt out the work to check that the theme responds appropriately to changing values in the configuration.
In this case, I think editing each field that affects the footer, and see how it plays.
We also mentioned the colour picker widget on all colour fields, which was originally an assumption of mine, but on discussion was generally agreed to be a nice thing to have and would not prevent entering other css values into the text field.
@finnlewis when you say "check language of the footer layout." do you mean the help text ?
I'm not sure, possibly how the layout options are described? @markconroy @richard-s-rowley do you recall what we mean by "git@github.com:localgovdrupal/localgov_microsites.git" ?
I think we meant the specific words we used for the layout options: 'full width', 'full with with content contained', etc
How about?
@finnlewis what do you think about the suggestion for the words
I like those suggestions
Sounds great for now, we'll get some feedback from the testing I'm sure,
PR here for field labels: https://github.com/localgovdrupal/localgov_microsites_group/pull/80
Mark has built out the form.
This has overrides for each colour and header width behaviour.
Todo: