localgovdrupal / localgov_microsites_base

Base theme for LocalGov Microsites
0 stars 1 forks source link

Display bug: Promoted IA block #151

Closed msayoung closed 1 year ago

msayoung commented 1 year ago

Image

Headings and links not picking up alt colour

msayoung commented 1 year ago

I think this was working so may be the fallout of moving css around

markconroy commented 1 year ago

Did you clear the cache?

msayoung commented 1 year ago

i did.

markconroy commented 1 year ago

I'm out of ideas.

msayoung commented 1 year ago

that's ok, i'll have a look. I have an idea

markconroy commented 1 year ago

Seems okay to me. Deliberatly choosing ugly colours to make sure.

Screenshot 2022-10-24 at 16 00 06

msayoung commented 1 year ago

try : no background colour on the section, and a dark secondary colour

markconroy commented 1 year ago

--color-page-section-background-color-1-link-color: var(--color-page-section-background-color-1-link-color);

Looks like we have a variable set to itself. Maybe that's giving us a cock up?

markconroy commented 1 year ago

That's kind of a "works as designed" item, which is a bit crap. The backgrounds chosen for the section don't have any knowledge that the paragraphs in the sections might have a background colour.

In this case, if we choose "light gray" for the background, then the featured ia-block says "hey, that's light grey, let's contrast that with black", but then the page section says "oooh, we're light grey, I bet black for text and links would be very oh la la".

I think we'll need some more varialbes for this class:

.page-section-background-color-3 .ia-block--featured {
  background-color: var(--some-new-varialbe);
  color: var(--some-other-new-variable)
}

.page-section-background-color-3 .ia-block--featured a {
  color: var(--some-other-new-variable-as-well)
}

And might want to repeat that for background colour 1 and 2 for page layout.