localgovdrupal / localgov_microsites_base

Base theme for LocalGov Microsites
0 stars 1 forks source link

Menus with sub-sub menus on hover #193

Closed msayoung closed 5 days ago

msayoung commented 1 year ago

@markconroy I think we still need to do some work on the menu on hover.

If we have a menu item with multiple children and some grandchildren eg

Screenshot from 2022-12-08 10-54-48

then when we hover over the first child we can hover to its child, but the menu disappears before we can hover over the second child.

Hard to describe, let's discuss.

markconroy commented 1 year ago

I've just noticed this too. Not sure why we are having this, but I'm sure we'll figure it out.

markconroy commented 1 year ago

From what I've been reading recently (and to make sure we have a similar experience for all users) we should not set hover states on menus, and instead make people explicitly click the 'expand' button, like keyboard users do.

That takes away a lot of the complexity of hover vs focus (and trying to keep them in tandem if someone clicks an expand button while hovering etc) and ensures all users perform the same actions.

I've a comment here - https://github.com/localgovdrupal/localgov_microsites_base/issues/219 - about moving to the Annertech disclosure library. Let's chat about that and see if we can solve a lot of the menu issues in one fell swoop.

xtianjohnson commented 1 month ago

I have been able to replicate this issue on one of the demo sites - https://site3.demo.microsites.localgovdrupal.org/

You can never get to the menu item encircled in red.

item disaapear

Don't know whether this a bug or but the 'Contact Us' sub item under the link 'Edward' is never revealed on the homepage when you pass your mouse over 'Edward'

sub item not displaying

Let me know if you need any further information.

markconroy commented 1 month ago

PR here: https://github.com/localgovdrupal/localgov_microsites_base/pull/268

markconroy commented 6 days ago

This should be fixed by https://github.com/localgovdrupal/localgov_microsites_base/pull/268 (updated version)