localgovdrupal / localgov_microsites_base

Base theme for LocalGov Microsites
0 stars 1 forks source link

Breadcrumb region doesn't pick up page_background on taxonomy term pages #197

Closed msayoung closed 1 year ago

msayoung commented 1 year ago

image

Set the page background colour to something not white. Add a taxonomy term View the taxonomy term page

markconroy commented 1 year ago

This is tricky, and I'm not sure we can actually fix it.

We have 2 variables

When we set a background colour for our microsite, that changes --page-background-colour to red/yellow/whatever and applies to the whole element. However, since we have explictly told --breadcrumbs-background-colour to be 'white', it remains so.

We could write something that says "if there is a value for --page-background-colour then force this to be the breadcrumb background colour too" but this might not be desired behaviour.

I'm open to suggestions on this one.

markconroy commented 1 year ago

And of course, just as I hit "send" above, I came up with a solution.

We could write something that says "if there is a value for --page-background-colour then force this to be the breadcrumb background colour too" but this might not be desired behaviour.

This is actually the solution I have gone for. I was thinking we could just add one line of CSS to set the breadcrumb colour per theme, but the point of microsites is that you don't need to create a theme per site, so it's probably a better behaviour for us to explictly set the breadcrumb background colour.

It can then be overridden on a per theme basis by setting !important such as --breadcrumb-background-colour: red !important;