search

localgovdrupal / localgov_news

Provides news articles and news listing pages for LocalGov Drupal
GNU General Public License v2.0
0 stars 2 forks source link

Remove config on uninstall #119

Closed zackdavies closed 2 weeks ago

zackdavies commented 2 weeks ago

Relates to https://github.com/localgovdrupal/localgov_news/issues/94 . Remove Pathauto settings, and add a field dependency on the module so that it uninstalls correctly.

andybroomfield commented 2 weeks ago

Thanks @zackdavies I can confirm this allows uninstall and reinstall. I noticed that pathauto.pattern.localgov_newsroom.yml doesn't have the enforced dependency, where as pathauto.pattern.localgov_news.yml does. Maybe thats whats causing the error? There are two content types, news article and newsroom.

zackdavies commented 2 weeks ago

Thanks Andy. Silly me, I've updated the YML and removed the uninstall hook and it works as intended.

zackdavies commented 2 weeks ago

Thanks Andy. Yes, if there's existing content you run into problems, but that seems intentional and out of the scope of this ticket. Can I merge this now, or do we wait for Merge Tuesday?

andybroomfield commented 2 weeks ago

I thin this is mergable