localgovdrupal / localgov_page_components

Reusable paragraphs library for LocalGovDrupal distribution.
GNU General Public License v2.0
0 stars 1 forks source link

Can't add new Contact Page component #22

Closed Adnan-cds closed 2 years ago

Adnan-cds commented 3 years ago

How to reproduce

Needs some digging in to find out what's happening inside the Gin/Claro themes.

@finnlewis @MattOz-CDS @stephen-cox @danchamp

danchamp commented 3 years ago

@Adnan-cds We came across this in Cumbria, it's a known issue for paragraph types with vertical tabs in Claro:

https://www.drupal.org/project/drupal/issues/3223319

Changing tabs to horizontal for the Contact paragraph type fixed it for us, I haven't tried the recent patch in the Drupal project issue.

danchamp commented 3 years ago

Sorry, I thought I'd raised issues for everything like this we came across, but this one slipped through the net.

Adnan-cds commented 3 years ago

Thanks Dan. Good to know it's a core bug.

Adnan-cds commented 3 years ago

The patch attached to the d.o ticket is outdated. A little tweak makes it usable, but I am unsure if the logic in the patch is fully reliable given there has not been much discussion around it yet. Telling the Contact Paragraph to use a Horizon tab in its form display works as you have said, but then its form looks odd. I am wondering what to do. @danchamp

Adnan-cds commented 2 years ago

No longer an issue following a core fix.