search

localgovdrupal / localgov_paragraphs

Configuration and dependencies for paragraphs components for the LocaGov Drupal distribution.
GNU General Public License v2.0
0 stars 5 forks source link

Add a span to within the button on accordion to allow for a GDS style show hide icon #169

Closed cjstevens78 closed 7 months ago

cjstevens78 commented 8 months ago

We have recently done a piece of work to bring the accordion in line with the GDS look and feel by introducing a 'show/hide' icon with text. Although there was provision for this type of thing in the JS (line 94) the icon would be output next to the button in the flow and we needed it to appear within the button. Rather than override this whole JS file within our theme and in order to make this functionality available to other users we thought it best to merge this back to the module. I have added one line of JS to insert the icon and a small amount of css to hide it initially so the change won't affect existing users of the accordion.

finnlewis commented 8 months ago

@markconroy @msayoung any chance you might be able to review this from a css perspective?

finnlewis commented 8 months ago

Oh, and thanks @cjstevens78 !

cjstevens78 commented 7 months ago

@markconroy @msayoung @finnlewis just chasing this up as im being asked when it'll be available. thanks chris

msayoung commented 7 months ago

Tests are failing though