search

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
10 stars 8 forks source link

ci: add PHP 8.2 support #130

Closed millnut closed 11 months ago

millnut commented 11 months ago

Unsure of the step failure here seems git related? Any ideas @stephen-cox @finnlewis

millnut commented 11 months ago

Ah drupal-container needs an 8.2 branch, just creating a branch for that shortly

millnut commented 11 months ago

Blocked by https://github.com/localgovdrupal/drupal-container/issues/31

millnut commented 11 months ago

@finnlewis https://github.com/localgovdrupal/localgov_project/actions/runs/6301829803/job/17137377456 gives a good overview of PHP 8.2 compatibility that needs looking at. If I have time this week/evening I'll cross reference with some recent PHP 8.2 merges and see what's left

finnlewis commented 11 months ago

Nice work @millnut - just need to go through the list of issues and maybe break out into separate issues for each problem repo. I note some are Drupal contrib too.

stephen-cox commented 11 months ago

All the test failures look to be because of deprecated code. We had some config that ignored deprecated errors in PHPUnit tests because many were caused by contrib and we assumed (hoped) that the PHPStan deprecated check would pick them up. Not sure why they are now only triggered when running in PHP 8.2 and not 8.1