localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
10 stars 8 forks source link

PHP 8.2 and PHPStan tracking #133

Closed millnut closed 8 months ago

millnut commented 9 months ago

This issue will track and link to individual module tickets that require PHP 8.2 fixes as well as fixes related to a recent change to PHPStan level to match Drupal core in https://github.com/localgovdrupal/localgov_project/pull/131

millnut commented 9 months ago

@finnlewis @Adnan-cds all of the LocalGov Drupal code above now has PRs for PHP 8.2 compatibility and/or needs a release. I have tested all these locally by running the project and then installing the demo module to check for deprecations. @Adnan-cds, if you spot any more PHP 8.2 deprecations, please let me know.

Once each has been merged and then releases created for each module I should be able to test the project workflows again once https://github.com/localgovdrupal/localgov_project/pull/130 and https://github.com/localgovdrupal/localgov_project/pull/131 are merged.

There are some deprecations on contrib modules in PHP 8.2 that we depend on such as Pathauto and Entity Browser but I would rather they create new releases than add a patch within LocalGov Drupal.

Once this is complete, I can look into the Microsites project and check what PHP 8.2 deprecations might be there.

finnlewis commented 8 months ago

Amazing, thanks @millnut

Closing this.