search

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
10 stars 8 forks source link

Making composer install /vendor/bin in the usual place and providing a link for /bin. #140

Closed gregharvey closed 4 months ago

gregharvey commented 9 months ago

Why?

Because lots of CI expect to find tools like drush in vendor/bin, it's the composer standard. I presume Lando needs the ./bin directory to contain these tools so it can present them? This solution attempts to make that available for Lando by committing a link, while allowing composer to install things in the "usual" places.

I understand if you don't accept this, it's just a suggestion and it only took a minute to make. :-)

gregharvey commented 9 months ago

Another option would be to fix the ddev and Lando configs (and GitHub Actions) so you don't need the composer line setting the bin dir at all?

finnlewis commented 4 months ago

@andybroomfield just mentioned that Acquia expects it to be in /vendor/bin.

andybroomfield commented 4 months ago

This is with Cloud next and cloud actions, after a call with an Acquia engineer. We're making that change to our composer.json to align with Acquia expectations, otherwise cloud actions fail as it can't find drush. As mentioned above this only affects new projects so we will need to document that change and rational for it.

finnlewis commented 4 months ago

Closing this in favour of #143 , thanks @gregharvey