search

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
10 stars 8 forks source link

fix: add patch level to composer.json #151

Closed andybroomfield closed 5 months ago

andybroomfield commented 6 months ago

Fix #150

Adds a patch level to project composer.json to add in development envrionments that require it.

ekes commented 6 months ago

@stephen-cox @millnut You both tested this on the issue, is it good to merge then?

stephen-cox commented 6 months ago

The change has killed composer install in GitHub CI. This is odd as it's running on Ubuntu and my tests on my desktop Ubuntu machine worked fine. I suspect there's a package missing from the CI environment.

I think this leads us to not merging this and documenting somewhere that Mac users will need to add this.

millnut commented 6 months ago

@stephen-cox I don't think the action failure is due to this change as re-running the action for https://github.com/localgovdrupal/localgov/pull/667 the patch that was added no longer applies https://github.com/localgovdrupal/localgov/actions/runs/7541566221/job/21529462321#step:10:853.

Looks like that patch needs updating to https://www.drupal.org/project/drupal/issues/2845144#comment-15439695

millnut commented 6 months ago

Waiting for a release containing this PR and will re-review

finnlewis commented 6 months ago

@millnut we just released https://github.com/localgovdrupal/localgov/releases/tag/3.0.3 with https://github.com/localgovdrupal/localgov/pull/678 merged.