Open finnlewis opened 4 months ago
Hi @finnlewis I think we shouldn't change this as we'd miss deprecations that might not be picked up by automated tooling and can only be flagged at runtime, so it is good to have these reported so they can be looked at, logged and fixed. Looking at Drupal core they also don't have this set up.
Question from Merge Tuesday. Is this possible to split out into another check run by github actions that raises a warning, but separate from the rest of the phpunit tests?
My main motivation here is to be able to see the results of the phpunit tests without the long list of deprecations.
Currently we've not been doing anything about the deprecations, so it gets in the way of seeing the test output, both locally and on Github.
I had wrongly assumed that these deprecations would be picked up in the phpstan job.
So for local test config, maybe we can enable this variable in the ddev or lando environments.
And/or we could look at running a separate job for the phpunit tests, suppressing deprecation notices, and one specifically for the deprecation notices. I've not found a way to do that just yet, any ideas?
Hi @finnlewis I'll take a look at this for local vs pipeline and create some tickets for the deprecations which mainly look D11 related, so makes sense we fix now rather than tests breaking when Drupal 11 is released.
Hi @finnlewis @ekes I've run the full tests locally with phpunit and it has come back with a lot of deprecations ~6250 which can't be detected by phpstan or upgrade status which makes the display of these important and should be fixed. I'm not sure if paratest is hiding these or something else on the workflows.
The majority of these seem to be a change in the install yaml file for each module which is due to be removed in Drupal 11. I'll give a brief overview below which we can discuss and then break into separate tickets to investigate further.
Crikey, thanks @millnut !
So we do want to keep an eye on these phpunit deprecations. Is there a way to run the phpunit tests twice, once for the actual tests and once for the deprecations? That might make it quicker to scan the results for what we're working on.
Set environment variable SYMFONY_DEPRECATIONS_HELPER for phpunit to disabled to suppress deprecation notices in phpunit output.