ci: use drupalci webdriver image

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.

https://localgovdrupal.org

GNU General Public License v2.0

10 stars 8 forks source link

ci: use drupalci webdriver image #159

Closed millnut closed 1 month ago

millnut commented 3 months ago

Change the chrome webdriver image to align with the DrupalCI image (https://www.drupal.org/docs/develop/automated-testing/phpunit-in-drupal/running-phpunit-javascript-tests#docker-compose)
Update the MINK_DRIVER_ARGS_WEBDRIVER to match DrupalCI
Uses the same image as our workflow drupal-container

finnlewis commented 1 month ago

Let's merge this one, even though the tests are not running.

At least this allows us to run functional javascript tests locally in Drupal 10.3!

stephen-cox commented 1 month ago

This isn't working locally for me

An unexpected error occurred while starting Mink: unknown error: net::ERR_CONNECTION_REFUSED
  (Session info: chrome-headless-shell=123.0.6312.58)
  (Driver info: chromedriver=123.0.6312.58 (6b4b19e9dfbb93aa414dc045bd445287977d8d7a-refs/branch-heads/6312_46@{#3}),platform=Linux 6.5.0-41-generic x86_64)

Will need to investigate what's going wrong.

millnut commented 1 month ago

@stephen-cox is this ddev or lando?

stephen-cox commented 1 month ago

@stephen-cox is this ddev or lando?

Lando

millnut commented 1 month ago

@stephen-cox is this ddev or lando?

Lando

Interesting have you run a lando rebuild, sometimes lando holds onto old config info unless a lando rebuild is run

stephen-cox commented 1 month ago

Yeah - I did a lando destroy as well as a rebuild and it's not working.

Just going through everything else prior to merge Tuesday so not done a full investigation yet. Will look further when I get a chance.

millnut commented 1 month ago

Thanks @stephen-cox I'll do some checks later

finnlewis commented 1 month ago

This doesn't work for @stephen-cox so needs a bit more testing.

millnut commented 1 month ago

Morning @stephen-cox I gave this a test this morning on an upgraded and clean install with Drupal 10.3 and it worked without issues:

lando phpunit web/modules/contrib/localgov_alert_banner/tests
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Testing /app/web/modules/contrib/localgov_alert_banner/tests
..................                                                18 / 18 (100%)

Time: 02:25.887, Memory: 12.00 MB

OK (18 tests, 293 assertions)

Happy to jump on a call to look at this in some more detail