search

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
10 stars 8 forks source link

Ignores Drupal 12 deprecation errors during static analysis checks #171

Closed MattOz-CDS closed 1 month ago

stephen-cox commented 1 month ago

@MattOz-CDS Any reason why this is marked as a draft? The test failures are unrelated to the change here and the deprecation checks are passing, so looking good to me.

MattOz-CDS commented 1 month ago

@stephen-cox Thanks for taking a quick peek at this one. It's in draft because I was thinking that I would need to fix these failures before pushing this forward for review. If you're happy for me to publish, then please may I, so that we can get this form issue merged.

finnlewis commented 1 month ago

Thanks for this @MattOz-CDS

It looks like the same changes are being made by this pull request: https://github.com/localgovdrupal/localgov_project/pull/153

But in a slightly different way. See my comment on https://github.com/localgovdrupal/localgov_project/pull/153#issuecomment-2270992248

This is all new to me, so just trying to understand which way is preferable.

MattOz-CDS commented 1 month ago

@finnlewis and @stephen-cox, that's no problem. I'lll close this one down. Thanks