search

localgovdrupal / localgov_project

Project template for Drupal 10 sites built with the LocalGov Drupal distribution.
https://localgovdrupal.org
GNU General Public License v2.0
11 stars 10 forks source link

Update Lando to use the Drupal9 recipe and PHP 8.1. #66

Closed finnlewis closed 2 years ago

finnlewis commented 2 years ago

I'm interested in people's thoughts on this.

It seems sensible to be testing against PHP 7.4 and 8.1 for now, which is what Thunder are doing, and to fix any tests that fail in their respective projects.

I think the PHP 8.1 coding standards tests are failing as the build is still pulling through PHP 7.4 from the main branch.

The PHPUnit tests will need looking at.

Any thoughts or suggestions on how to improve this?

Adnan-cds commented 2 years ago

Any thoughts or suggestions on how to improve this?

Hi Finn, I see only one error which is about the localgov_openreferral module. It looks as if the HTTP response for an unpublished organization type record is missing the "Content-Type" header which is leading to all the errors. Needs more digging. @ekes is the best person to look into this IMHO.

finnlewis commented 2 years ago

Woop woop! Nice work @stephen-cox @ekes @markconroy @Adnan-cds @andybroomfield