search

localgovdrupal / localgov_publications

HTML Publications for LocalGov Drupal. Stop making PDFs!
https://gds.blog.gov.uk/2018/07/16/why-gov-uk-content-should-be-published-in-html-and-not-pdf/
GNU General Public License v2.0
2 stars 3 forks source link

Dependency on deprecated "Book" module #180

Open millnut opened 3 months ago

millnut commented 3 months ago

This module depends on the deprecated drupal:book module https://www.drupal.org/node/3223395#s-book

Are there plans to not depend on this module that will no longer be part of the core in Drupal 11

rupertj commented 2 months ago

We'll have to stop depending on the core version of book and depend on the contrib one instead, which I suspect means I'll need to make a new major version of localgov_publications to do that.

rupertj commented 2 months ago

I've started a 2.x branch for Drupal 11 onwards: https://github.com/localgovdrupal/localgov_publications/tree/2.x

andybroomfield commented 2 months ago

Contrib book works on d10 also so we could move 1.x to that.

rupertj commented 2 months ago

I hadn't thought of that. Is it possible to install it while core book is still in place?

andybroomfield commented 2 months ago

I think so, though internally the namespace of functions / services might have changed...

rupertj commented 2 months ago

I've just tried this out and it works! So I'll bin the new 2.x branch and make 1.x use contrib book.