Make the header search field required in the block plugin rather than using a hook_form_alter

[stephen-cox]

Closes #6

[stephen-cox]

The issue (#6) this fixes has been reported in Slack by someone demoing LGD. Tagging more reviewers as getting this fixes is high priority.

[ekes]

If we're placing the form anyway it makes sense to edit the form directly ourselves.

I'm just baffled why hook_form_alter would cause an empty message, and adding it to the form wouldn't?

[stephen-cox]

I'm just baffled why hook_form_alter would cause an empty message, and adding it to the form wouldn't?

Same here - I'm thinking there's some sort of extra processing going on either before the search form gets form altered, but haven't spent much time delving into what's going on

[ekes]

Well if it's high priority and works when it's on the form when first passed in...

[finnlewis]

Well if @ekes is happy, merge it!