Search block: Placeholder & Button text

[budda]

Currently, the search form submit button label says "Apply" which doesn't make sense.

Some councils use "GO" as the button text, others have simply got an icon for a button.

[markconroy]

• I don’t like the word “Go”. I’m not sure that signifies what the form is going to do. If we are going to change the word, I’d suggest we change it to “Search”, since this is what will happen when you press the button.
• I’d be against the idea of an icon only (at least in our base theme) from the point-of-view of accessibilty. At minimum we’d need to have text that’s available to screen readers to say “Apply” or “Go” or “Search” (so we’re back again to the first question - what should the word be?

[budda]

At the moment the placeholder text in the textfield says "Search" too -- maybe that should be "keyword" or "phrase" otherwise the UI looks like

[willguv]

@markconroy how about "Search" as that's what the button does

[markconroy]

Looks like this is an issue for the Localgov Search module, not the base theme, as it's stored in config there: https://github.com/localgovdrupal/localgov_search/blob/1.x/config/install/views.view.localgov_sitewide_search.yml

[markconroy]

@finnlewis Do you know how to transfer an issue from one repo to another? If so, can you move this to LocalGov Search module please?

[ekes]

• The placeholder text is hardcoded into the module. It should at least be wrapped in a $this->t(), it should better use the configuration value, so it can be altered per-site.
• If the 'Search' can be changed in configuration we should make sure this works, and is documented somewhere.

[markconroy]

 * Implements hook_form_alter().
 */
function lgd_form_alter(&$form, $form_state, $form_id) {
  dpm($form_id);
  dpm($form);
}```

Those `dpm`s return the form from the view, not the form from our custom code.  So you can't get at our custom code form to alter the placeholder, it will only alter the placeholder from the view version (on the /search page).