search

localgovdrupal / localgov_search

Default sitewide search implementation for LocalGov Drupal.
GNU General Public License v2.0
0 stars 1 forks source link

Issue #29: Just splitting db server into another module #40

Closed ekes closed 2 years ago

finnlewis commented 2 years ago

Would be good to get some other eyes on this before merging.

finnlewis commented 2 years ago

@andybroomfield @stephen-cox @Adnan-cds it woudl be great to get some more eyes on this, especially on existing installed sites.

This will free up enabling different backends.

finnlewis commented 2 years ago

This is linked to https://github.com/localgovdrupal/localgov_directories/pull/206

finnlewis commented 2 years ago

From discussion in the search working group:

@ekes thinks it would be good to write an update path to enable the module but not install it's config!

@ekes will need to look at this before further testing.

ekes commented 2 years ago

I noticed that the search block is available on a fresh LocalGov site with the localgov_search module enabled and the localgov_search_db submodule disabled.

What about https://github.com/localgovdrupal/localgov_search/pull/40/commits/32fd1d26ec35aec82361525cfeaae35ebdc4af52

finnlewis commented 2 years ago

Discussion in Merge Monday. To anyone with an existing site, this change should have no noticeable effect. People with current fresh builds might need to change the config of their install process to include the new sub-module. Adnan has reviewed and approved. Version number will bump the minor version to 1.1.0 So any objections to merging and doing a release? None.