search

localgovdrupal / localgov_services

Provides the pages and navigation for presenting the Services provided by Local Government. A part of the LocalGovDrupal distribution.
GNU General Public License v2.0
3 stars 5 forks source link

Test failures with localgov_services_navigation LandingPageChildrenTest:testServiceLandingPageLink #271

Closed stephen-cox closed 3 months ago

stephen-cox commented 3 months ago

There are currently a couple of failing in the localgov_services_navigation module

2) Drupal\Tests\localgov_services_navigation\FunctionalJavascript\LandingPageChildrenTest::testServiceLandingPageLink
Behat\Mink\Exception\ExpectationException: The field "edit-localgov-common-tasks-0-uri" value is "/node/4", but "/node/2" expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:781
/var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:987
/var/www/html/web/modules/contrib/localgov_services/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php:133
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

3) Drupal\Tests\localgov_services_navigation\FunctionalJavascript\LandingPageChildrenTest::testServiceLandingPageReference
Behat\Mink\Exception\ExpectationException: The field "edit-localgov-destinations-0-target-id" value is "and last one left (4)", but "( bob )"; (3)" expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:781
/var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:987
/var/www/html/web/modules/contrib/localgov_services/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php:213
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
stephen-cox commented 3 months ago

Seems to be fixed with https://github.com/localgovdrupal/localgov_services/pull/267

Would be good to get this released with #272 then all the tests are passing.