search

localgovdrupal / localgov_shared_workflows

GNU General Public License v2.0
0 stars 0 forks source link

Eslint and Stylelint coding standards on github workflows? #10

Open millnut opened 3 months ago

millnut commented 3 months ago

Now that shared workflows are on all modules, do we want to consider setting up eslint checks (for js files) and stylelint checks (for css files) so we are aligned with Drupal's coding standards for these? We currently use Drupal coding standards for PHP related files so aligning on the JS/CSS side as well would help with consistency.

@markconroy would be good to get your thoughts on this?

markconroy commented 3 months ago

Yes, I think this is a great idea.

We do have stylelint in the localgov_base theme, but you need to manually run it, which only happens periodically.

We have no eslint for JS files.