Closed markconroy closed 2 years ago
Hey @markconroy
The tests are failing on this with a PHP version problem:
Error: Your requirements could not be resolved to an installable set of packages.
Problem 1
- brianium/paratest 4.0.0 requires php ^7.1 -> your php version (8.0.3) does not satisfy that requirement.
- brianium/paratest[4.1.0, ..., 4.2.0] require php ^7.3 -> your php version (8.0.3) does not satisfy that requirement.
- Root composer.json requires brianium/paratest ^4.0.0 -> satisfiable by brianium/paratest[4.0.0, ..., 4.2.0].
I think the PHP version has been specified in the localgov-drupal-ci.yml since you forked this:
vs
If you merge the latest updates from master into your branch, I guess the PR will update and trigger the tests again, which should then not fail on the PHP version issue at least.
So the only difference master
to markconroy:2021_03_coding_standards_tweaks
now seems to be templates/node/node--teaser.html.twig div
changing to article
, which I assume would need a change notice at least.
So running through localgovdrupal/localgov#200 tagging I'll leave this till a stable is tagged.
@markconroy we're closing this as localgov_skeleton is DEPRECATED
Some coding standards for Twig/Drupal to make the code a little easier to read.