search

localgovdrupal / localgov_skeleton

⛔️ DEPRECATED (Bare base theme for LocaGov Drupal sites with no styling.)
GNU General Public License v2.0
0 stars 3 forks source link

2021 03 coding standards tweaks #14

Closed markconroy closed 2 years ago

markconroy commented 3 years ago

Some coding standards for Twig/Drupal to make the code a little easier to read.

finnlewis commented 3 years ago

Hey @markconroy

The tests are failing on this with a PHP version problem: 

Error: Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - brianium/paratest 4.0.0 requires php ^7.1 -> your php version (8.0.3) does not satisfy that requirement.
    - brianium/paratest[4.1.0, ..., 4.2.0] require php ^7.3 -> your php version (8.0.3) does not satisfy that requirement.
    - Root composer.json requires brianium/paratest ^4.0.0 -> satisfiable by brianium/paratest[4.0.0, ..., 4.2.0].

I think the PHP version has been specified in the localgov-drupal-ci.yml since you forked this:

https://github.com/localgovdrupal/localgov_skeleton/blob/master/.github/workflows/localgov-drupal-ci.yml#L18

vs

https://github.com/markconroy/localgov_skeleton/blob/2021_03_coding_standards_tweaks/.github/workflows/localgov-drupal-ci.yml

If you merge the latest updates from master into your branch, I guess the PR will update and trigger the tests again, which should then not fail on the PHP version issue at least.

ekes commented 3 years ago

So the only difference master to markconroy:2021_03_coding_standards_tweaks now seems to be templates/node/node--teaser.html.twig div changing to article, which I assume would need a change notice at least.

So running through localgovdrupal/localgov#200 tagging I'll leave this till a stable is tagged.

finnlewis commented 2 years ago

@markconroy we're closing this as localgov_skeleton is DEPRECATED